[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove obsolete kokoro configs and update DocFX profile #1934

Merged
merged 10 commits into from
Mar 25, 2024

Conversation

alicejli
Copy link
Contributor

Partial fix for #1933 (the other part of the fix will be in g3)

This removes the kokoro release configs as that was migrated to g3. This also updates the DocFX profile such that it javadoc generation will work. This repo doesn't inherit from java-shared-config AFAIK.

@alicejli alicejli requested a review from a team as a code owner March 21, 2024 21:12
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Mar 21, 2024
Copy link
generated-files-bot bot commented Mar 21, 2024

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml
  • .kokoro/dependencies.sh
  • .kokoro/release/bump_snapshot.cfg
  • .kokoro/release/common.cfg
  • .kokoro/release/common.sh
  • .kokoro/release/drop.cfg
  • .kokoro/release/drop.sh
  • .kokoro/release/promote.cfg
  • .kokoro/release/promote.sh
  • .kokoro/release/publish_javadoc.cfg
  • .kokoro/release/publish_javadoc.sh
  • .kokoro/release/publish_javadoc11.cfg
  • .kokoro/release/publish_javadoc11.sh
  • .kokoro/release/snapshot.cfg
  • .kokoro/release/snapshot.sh
  • .kokoro/release/stage.cfg
  • .kokoro/release/stage.sh

@alicejli
Copy link
Contributor Author

We can't add Java 21 to the series of tests due to compilation error:

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project google-http-client: Compilation failure: Compilation failure: 
Error:  Source option 7 is no longer supported. Use 8 or later.
Error:  Target option 7 is no longer supported. Use 8 or later.
Error:  -> [Help 1]

That's the reasoning behind the custom test that compiles with 8 and then tests with 21: https://github.com/googleapis/google-http-java-client/blob/main/.github/workflows/ci.yaml#L90

@alicejli alicejli merged commit 9fe11d9 into main Mar 25, 2024
21 checks passed
@alicejli alicejli deleted the updateDocFxProfile branch March 25, 2024 14:14
@suztomo
Copy link
Member
suztomo commented Mar 25, 2024

Do we use docFX for this repository?

@suztomo
Copy link
Member
suztomo commented Mar 25, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants