WIP: Update logging gapic yaml #208
Conversation
Added folder and billingAccounts Moved new formats to top-level collection config, so that additional format and parse methods are not generated
| collection_oneofs: | ||
| - oneof_name: parent_oneof | ||
| collection_names: | ||
| - parent | ||
| - organization | ||
| - folder | ||
| - billing | ||
| - oneof_name: sink_oneof | ||
| collection_names: | ||
| - sink |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| - oneof_name: sink_oneof | ||
| collection_names: | ||
| - sink | ||
| - organization_sink | ||
| - folder_sink | ||
| - billing_sink | ||
| - oneof_name: log_oneof | ||
| collection_names: | ||
| - log |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -19,6 +19,55 @@ language_settings: | |||
| license_header: | |||
| copyright_file: copyright-google.txt | |||
| license_file: license-header-apache-2.0.txt | |||
| collections: | |||
| - name_pattern: projects/{project} | |||
| entity_name: parent | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Rename parent collection to project Rename log to project_log Rename sink to project_sink
There was a problem hiding this comment.
Updated with these changes. Definitely agree about parent->project.
I can see the argument both ways for log vs project_log and sink vs. project_sink. They are the most common, so there is an advantage to keeping the names simple, even if that is less consistent with the others.
|
LGTM |
This regeneration is for googleapis/googleapis#208. Basically, it changes the name of 'parentPath' to 'projectPath', and we believe the new name is more understandable. This regeneration happens to include a minor change on the codegen to support LRO -- however this does not require any updates on dependencies. Simple style changes.
This regeneration is for googleapis/googleapis#208. Basically, it changes the name of 'parentPath' to 'projectPath', and we believe the new name is more understandable. This regeneration happens to include a minor change on the codegen to support LRO -- however this does not require any updates on dependencies. Simple style changes.
|
Forgot to remove "WIP" from the commit message. ;) |
|
Oops... do you think this is worth amending and force-pushing to update? |
|
No, let's not force update anything on master. Just pointing out in case anyone is wondering why a WIP was merged ('cause it's not really a WIP anymore). |
|
OK no worries! |
This regeneration is for googleapis/googleapis#208. Basically, it changes the name of 'parentPath' to 'projectPath', and we believe the new name is more understandable. This regeneration happens to include a minor change on the codegen to support LRO -- however this does not require any updates on dependencies. Simple style changes.
Updates logging to use resource names