[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix ITJdbcConnectTest for custom server url #1098

Merged
merged 3 commits into from
Jan 13, 2023
Merged

test: fix ITJdbcConnectTest for custom server url #1098

merged 3 commits into from
Jan 13, 2023

Conversation

rajatbhatta
Copy link
Contributor

No description provided.

@rajatbhatta rajatbhatta requested a review from a team as a code owner January 13, 2023 07:49
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner-jdbc API. labels Jan 13, 2023
gauravpurohit06
gauravpurohit06 approved these changes Jan 13, 2023
View reviewed changes
Copy link
@gauravpurohit06 gauravpurohit06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rajatbhatta rajatbhatta added the automerge Merge the pull request once unit tests and other checks pass. label Jan 13, 2023
olavloite
olavloite approved these changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator
@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add a comment and use a character literal instead of 58 to make it more readable.

src/test/java/com/google/cloud/spanner/jdbc/it/ITJdbcConnectTest.java Outdated Show resolved Hide resolved
@olavloite olavloite removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 13, 2023
@rajatbhatta rajatbhatta merged commit 218c758 into main Jan 13, 2023
@rajatbhatta rajatbhatta deleted the fix-itjdbcconnecttest branch January 13, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@gauravpurohit06 gauravpurohit06 gauravpurohit06 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rajatbhatta @olavloite @gauravpurohit06