[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update retry policy to not retry streams that have not made progress receiving documents #1946

Merged
merged 5 commits into from
Nov 17, 2023
Merged

fix: update retry policy to not retry streams that have not made progress receiving documents #1946

merged 5 commits into from
Nov 17, 2023

Conversation

MarkDuckworth
Copy link
Contributor
@MarkDuckworth MarkDuckworth commented Nov 14, 2023 •
edited
Loading

BEGIN_COMMIT_OVERRIDE
fix: update retry policy to not retry streams that have not made progress receiving documents
END_COMMIT_OVERRIDE

@MarkDuckworth MarkDuckworth requested review from a team as code owners November 14, 2023 19:41
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 14, 2023
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link
conventional-commit-lint-gcf bot commented Nov 14, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Nov 14, 2023
@MarkDuckworth MarkDuckworth changed the title fix: Update retry policy to not retry streams that have not made progress. fix: Update retry policy to not retry streams that have not made progress Nov 14, 2023
@MarkDuckworth MarkDuckworth changed the title fix: Update retry policy to not retry streams that have not made progress fix: update retry policy to not retry streams that have not made progress Nov 14, 2023
@MarkDuckworth MarkDuckworth changed the title fix: update retry policy to not retry streams that have not made progress update retry policy to not retry streams that have not made progress Nov 14, 2023
@MarkDuckworth MarkDuckworth changed the title update retry policy to not retry streams that have not made progress fix: update retry policy to not retry streams that have not made progress Nov 14, 2023
tom-andersen
tom-andersen reviewed Nov 14, 2023
View reviewed changes
dev/src/reference.ts Outdated Show resolved Hide resolved
tom-andersen
tom-andersen reviewed Nov 14, 2023
View reviewed changes
dev/test/query.ts Outdated Show resolved Hide resolved
@MarkDuckworth
Copy link
Contributor Author

Aggregate queries should not be retried.

@MarkDuckworth MarkDuckworth mentioned this pull request Nov 15, 2023
Open
@MarkDuckworth MarkDuckworth added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 15, 2023
tom-andersen
tom-andersen requested changes Nov 15, 2023
View reviewed changes
dev/test/query.ts Outdated Show resolved Hide resolved
dev/test/query.ts Outdated Show resolved Hide resolved
dev/src/reference.ts Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Nov 16, 2023
@MarkDuckworth MarkDuckworth removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 16, 2023
tom-andersen
tom-andersen requested changes Nov 17, 2023
View reviewed changes
dev/test/query.ts Outdated Show resolved Hide resolved
dev/test/query.ts Outdated Show resolved Hide resolved
dev/test/query.ts Show resolved Hide resolved
dev/src/reference.ts Outdated Show resolved Hide resolved
tom-andersen
tom-andersen approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor
@tom-andersen tom-andersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkDuckworth MarkDuckworth added the automerge Merge the pull request once unit tests and other checks pass. label Nov 17, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 170d05b into main Nov 17, 2023
18 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the markduckworth/fix-stream-retry-without-progress branch November 17, 2023 21:06
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 17, 2023
@release-please release-please bot mentioned this pull request Nov 17, 2023
Merged
@MarkDuckworth MarkDuckworth changed the title fix: update retry policy to not retry streams that have not made progress fix: update retry policy to not retry streams that have not made progress receiving documents Nov 20, 2023
@MarkDuckworth MarkDuckworth added the release-please:force-run To run release-please label Nov 20, 2023
@release-please release-please bot removed the release-please:force-run To run release-please label Nov 20, 2023
@MarkDuckworth MarkDuckworth added the release-please:force-run To run release-please label Nov 20, 2023
@release-please release-please bot removed the release-please:force-run To run release-please label Nov 20, 2023
@MarkDuckworth MarkDuckworth added the release-please:force-run To run release-please label Nov 20, 2023
@release-please release-please bot removed the release-please:force-run To run release-please label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-andersen tom-andersen tom-andersen approved these changes

@ehsannas ehsannas Awaiting requested review from ehsannas

Assignees

@ehsannas ehsannas

@tom-andersen tom-andersen

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarkDuckworth @tom-andersen @ehsannas