[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: consolidate PyarrowVersions helpers #1679

Merged
merged 16 commits into from
Oct 18, 2023
Merged

chore: consolidate PyarrowVersions helpers #1679

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
96aa245
chore: consolidate pyarrow helpers
Linchin Oct 9, 2023
cc9918d
complete refactor
Linchin Oct 9, 2023
9804f3f
Merge branch 'main' into pyarrow
Linchin Oct 9, 2023
4e54c0f
consolidate pyarrow version checking usage
Linchin Oct 9, 2023
ae5a434
add unit tests
Linchin Oct 9, 2023
fb9aa5f
Merge branch 'googleapis:main' into pyarrow
Linchin Oct 9, 2023
76b5cd0
fix unit_noextras testing error
Linchin Oct 9, 2023
d0f8e42
fix tests
Linchin Oct 10, 2023
4c3adef
Merge branch 'main' into pyarrow
Linchin Oct 11, 2023
6e8d8a5
Merge branch 'main' into pyarrow
Linchin Oct 13, 2023
465e378
address comments
Linchin Oct 14, 2023
ab266a7
fix tests
Linchin Oct 16, 2023
1903dae
coverage
Linchin Oct 16, 2023
b6cec08
accept suggestion
Linchin Oct 17, 2023
0b827e0
accept suggestion
Linchin Oct 17, 2023
c1b8d0d
address comments
Linchin Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
accept suggestion 
Co-authored-by: Tim Swast <swast@google.com>
  • Loading branch information
@Linchin @tswast
Linchin and tswast committed Oct 17, 2023
commit b6cec0858d90bcca2fa07de5d2e184fe4d236d97
7 changes: 1 addition & 6 deletions tests/unit/test__pyarrow_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,7 @@
import pytest


try:
import pyarrow
except ImportError: # pragma: NO COVER
pyarrow = None
pyarrow = pytest.importorskip("pyarrow", minversion="3.0.0")


@pytest.fixture
Expand All @@ -28,7 +25,6 @@ def module_under_test():
return _pyarrow_helpers


@pytest.mark.skipIf(pyarrow is None, reason="Requires `pyarrow`")
def test_bq_to_arrow_scalars(module_under_test):
assert (
module_under_test.bq_to_arrow_scalars("BIGNUMERIC")
Expand All @@ -37,7 +33,6 @@ def test_bq_to_arrow_scalars(module_under_test):
assert module_under_test.bq_to_arrow_scalars("UNKNOWN_TYPE") is None


@pytest.mark.skipIf(pyarrow is None, reason="Requires `pyarrow`")
def test_arrow_scalar_ids_to_bq(module_under_test):
assert module_under_test.arrow_scalar_ids_to_bq(pyarrow.bool_().id) == "BOOL"
assert module_under_test.arrow_scalar_ids_to_bq("UNKNOWN_TYPE") is None