[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: rename exports to tools #9135

Merged
merged 6 commits into from
Jun 8, 2019
Merged

report: rename exports to tools #9135

merged 6 commits into from
Jun 8, 2019

Conversation

connorjclark
Copy link
Collaborator

On account of "Toggle Dark Theme" having nothing to do with exporting.

exterkamp
exterkamp reviewed Jun 6, 2019
View reviewed changes
Copy link
Member
@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

patrickhulce
patrickhulce approved these changes Jun 6, 2019
View reviewed changes
Copy link
Collaborator
@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I guess we already changed to three dots huh too :)

LGTM!

@connorjclark @patrickhulce
Update lighthouse-core/report/html/templates.html
ce6acda 
Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jun 6, 2019
brendankenny
brendankenny approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member
@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update the instance in fileoverview and should probably rename onExport, but otherwise LGTM

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@connorjclark connorjclark changed the title misc: rename exports to tools report: rename exports to tools Jun 7, 2019
@connorjclark connorjclark merged commit 0e221e5 into master Jun 8, 2019
@paulirish paulirish deleted the exports-to-tool branch June 10, 2019 17:27
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@exterkamp exterkamp exterkamp left review comments

@brendankenny brendankenny brendankenny approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@connorjclark @googlebot @brendankenny @patrickhulce @exterkamp