[go: nahoru, domu]

Skip to content
This repository has been archived by the owner on Oct 19, 2023. It is now read-only.

Update README.rst #151

Closed
wants to merge 1 commit into from
Closed

Conversation

JamesDrummond
Copy link

With windows 10 need to run pip install --upgrade setuptools. Haven't tried this with Linux but I figure it wouldn't hurt to make things work on both windows/linux minus the sudo apt-get

With windows 10 need to run `pip install --upgrade setuptools`. Haven't tried this with Linux but I figure it wouldn't hurt to make things work on both windows/linux minus the `sudo apt-get`
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@Fleker Fleker requested a review from proppy December 29, 2017 02:44
@Fleker
Copy link
Contributor
Fleker commented Dec 29, 2017

This seems okay. It shouldn't hurt anything if it is not needed.

@JamesDrummond
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@proppy
Copy link
Contributor
proppy commented Jan 9, 2018

Maybe we could add this in a pre-requisites section, like we do for the samples:
https://github.com/googlesamples/assistant-sdk-python/tree/master/google-assistant-sdk/googlesamples/assistant/grpc#prerequisites

@Fleker
Copy link
Contributor
Fleker commented Jan 9, 2018

We could consolidate the dependencies into a pre-req section. It would definitely be more useful, but it depends whether @JamesDrummond wants to do that. The PR looks good and we could consolidate after.

@JamesDrummond
Copy link
Author

@Fleker I would keep it the way I have it. I think that README.rst that @proppy mentions already has this in it with env/bin/python -m pip install --upgrade pip setuptools but I don't know if it needs to be after sudo apt-get install portaudio19-dev libffi-dev libssl-dev. Not actively working with this anymore so I cannot test.

Unfortunately, I didn't even know about the other README's. I think for future effort maybe install and running detail should be removed from https://github.com/googlesamples/assistant-sdk-python/blob/master/google-assistant-sdk/README.rst and then reference the sub README's for additional information.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants