[go: nahoru, domu]
Skip to content

Commit

Permalink
Updated Github URL at the update checker
Browse files Browse the repository at this point in the history
  • Loading branch information
hoyinm14mc committed Oct 29, 2017
1 parent f6921cc commit 8602d04
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions changelog.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ Changelog of Jail
- Removed duplicated software icon file in the source code itself
- Improved accuracy of update fetcher's version comparing techniques
- Fixed duplication of unjail message when players successfully unjail by bail
- Updated Github URL at the update checker
- Caution: This update MAY NOT be COMPATIBLE with the latest PocketMine BETA versions

1.2.0 - 11/AUG/2017
- Update fetcher now shows update changes of the latest version for Poggit or Github
Expand Down
2 changes: 1 addition & 1 deletion plugin.yml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Jail
main: hoyinm14mc\jail\Jail
api: ["2.0.0", "3.0.0-ALPHA3", "3.0.0-ALPHA4", "3.0.0-ALPHA5", "3.0.0-ALPHA6", "3.0.0-ALPHA7"]
version: 1.2.0
version: 1.2.1
author: hoyinm14mc
description: An advanced jail punishment system for PocketMine servers
load: POSTWORLD
Expand Down
2 changes: 1 addition & 1 deletion resources/config.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,4 @@ update-checker-channel: '*'

### Config version ###
#Do not modify this, otherwise plugin may not work properly
v: 1.2.0
v: 1.2.1
4 changes: 2 additions & 2 deletions src/hoyinm14mc/jail/tasks/updater/AsyncUpdateChecker.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function onRun()
{
$arr = [];
//Github Channel
$git_iden = json_decode(Utils::getURL("https://api.github.com/repos/hoyinm14mc/Jail/releases"), true);
$git_iden = json_decode(Utils::getURL("https://api.github.com/repos/gordonmhy/Jail/releases"), true);
$git_iden_latest = $git_iden[0];
//Poggit Channel
$serverApi = \pocketmine\API_VERSION;
Expand All @@ -63,7 +63,7 @@ public function onRun()
$key++;
}
$arr["poggit_desc"] = $git_iden[$key]["body"];
$arr["github_dllink"] = "https://github.com/hoyinm14mc/Jail/releases/tag/" . $git_iden_latest["tag_name"];
$arr["github_dllink"] = "https://github.com/gordonmhy/Jail/releases/tag/" . $git_iden_latest["tag_name"];
$arr["poggit_dllink"] = "https://poggit.pmmp.io/p/Jail/" . $git_iden[$key]["tag_name"];
$this->setResult($arr);
}
Expand Down

2 comments on commit 8602d04

@SOF3
Copy link
@SOF3 SOF3 commented on 8602d04 Nov 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I almost banned you for plagiarizing hoyinm14mc's plugins :P

@SOF3
Copy link
@SOF3 SOF3 commented on 8602d04 Nov 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate that you wrote very interesting headers for Jail's plugin description, but with Poggit's tabs formatting update (take a look at how the description looks: https://poggit.pmmp.io/p/Jail/1.2.1), it is better to switch to shorter headers. You may keep the current headers in smaller header levels, e.g.:

## Safe and Secure. The lock never breaks.
Malfunction of a prison's security features is not allowed in reality. Security always comes first, so Jail forces players to stay in their prisons, even when the prison is not sealed with blocks. Controls is limited to players in jail, so they never break out of prison. Learn More.

Can be changed to:

## Security
### Safe and Secure. The lock never breaks.
Malfunction of a prison's security features is not allowed in reality. Security always comes first, so Jail forces players to stay in their prisons, even when the prison is not sealed with blocks. Controls is limited to players in jail, so they never break out of prison. Learn More.

The smaller header is still displayed on the "Security" tab, but the tab list can get much more user-friendly.

Perhaps you could change this:
image
into more brief names, e.g. "Plugin integration", "Simple configuration", "Secure", etc.

To be honest, your description is linguistically very attractive, but it makes it slightly difficult to navigate information. For example, if I just want to know what features your plugin has, I have to switch to your wiki, which I cannot find until I switch to the second last tab (or scroll to the almost-bottom, if users disabled tabs formatting). You may consider improving this. In particular, passers-by who want to know more about your plugin only see how you brag about your plugin (no offense, this is normal in promotion texts) without actually getting a clear feature list. Poggit's tabs formatting update was to make information easier to navigate, but when the description itself isn't very informative, it may not be working so well.

Please sign in to comment.