[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Memory leak in BottomSheetBackdrop #1167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Memory leak in BottomSheetBackdrop #1167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix Memory leak in BottomSheetBackdrop 
Fix Memory leak in BottomSheetBackdrop that occurs when the backdrop tries to set the `pointerEvents` to `none` when dismissing the modal even though we don't need to. If the `disappearsOnIndex` is set to `-1` and the `animatedIndex` is `<= -1` , there is no need to call `setEventPointers` since the modal should be removed.
  • Loading branch information
@tsukudabuddha
tsukudabuddha committed Nov 4, 2022
commit 6ab4baa246976309d60b169717ef2a1860260997
2 changes: 1 addition & 1 deletion src/components/bottomSheetBackdrop/BottomSheetBackdrop.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ const BottomSheetBackdropComponent = ({
useAnimatedReaction(
() => animatedIndex.value <= disappearsOnIndex,
(shouldDisableTouchability, previous) => {
if (shouldDisableTouchability === previous) {
if (shouldDisableTouchability === previous || disappearsOnIndex === -1) {
return;
}
runOnJS(handleContainerTouchability)(shouldDisableTouchability);
Expand Down