Support multiple authentication methods for S3 #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
annanay25
approved these changes
Nov 4, 2020
There was a problem hiding this comment.
Fantastic work, LGTM and thank you @chancez! I just have a few requests -
- Could you please add a documentation section highlighting the different authentication methods that can be used with the
s3backend? Ideally underdocs/tempo/websiteso its easily accessible? - We'll need a signed CLA to merge this PR
|
Ok rebased, I signed the CLA, and added some documentation indicating supported authentication methods for S3. I wasn't sure where the best place to put the docs were, but I'm glad to make updates to them. |
annanay25
reviewed
Nov 5, 2020
Adds support for AWS IRSA, IAM roles, static credentials, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Updates minio to v7 and configures a credentials chain that allows using
multiple authentication methods for accessing S3. In particular this
enables IRSA
https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts.html.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]