[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

balancer: add server loads from RPC trailers to DoneInfo #2641

Merged
merged 2 commits into from
Apr 2, 2019
Merged

balancer: add server loads from RPC trailers to DoneInfo #2641

merged 2 commits into from
Apr 2, 2019

Conversation

menghanl
Copy link
Contributor

ServerLoad is added to DoneInfo as a separate field, to avoid parsing in both parent balancers and child balancers.

Also added load parsing APIs, but kept them in internal for now.

dfawley
dfawley approved these changes Feb 13, 2019
View reviewed changes
internal/balancerload/load.go Show resolved Hide resolved
internal/balancerload/load.go Show resolved Hide resolved
internal/balancerload/load.go Outdated Show resolved Hide resolved
internal/balancerload/orca/orca_test.go Outdated Show resolved Hide resolved
@menghanl menghanl self-assigned this Feb 15, 2019
@menghanl menghanl merged commit d389f9f into grpc:master Apr 2, 2019
@menghanl menghanl deleted the xds_load_report branch April 2, 2019 18:15
@menghanl menghanl changed the title balancer: add server loads from RPC trailers balancer: add server loads from RPC trailers to DoneInfo Apr 2, 2019
@therc
Copy link
Contributor
therc commented Apr 2, 2019

Is there any documentation or roadmap about orca? I'm happy to see all of this becoming public, a decade after using it internally. :-)

@menghanl
Copy link
Contributor Author
menghanl commented Apr 2, 2019

@therc I believe we don't have any public doc for orca now.
We are planning to use orca for server load reporting in xds balancer, and will make it public in the process. This PR is part of it.

@dfawley dfawley added the Type: Feature New features or improvements in behavior label Apr 4, 2019
@dfawley dfawley added this to the 1.20 Release milestone Apr 4, 2019
@menghanl
Copy link
Contributor Author

@therc FYI envoyproxy/envoy#6497

@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@menghanl menghanl

Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
1.20 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@menghanl @therc @dfawley