describe how to add mruby modules #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazuho
reviewed
Jun 26, 2017
CONTRIBUTING.md
Outdated
| # Mruby modules | ||
|
|
||
| It is possible to add additional mruby modules. | ||
| All modules that match `Dir.glob("../mruby-*/mrbgem.rake")` get linked. Copy (or git-submodule) the library under `deps/` and rerun make. |
There was a problem hiding this comment.
Could we add a link to https://github.com/h2o/h2o/wiki/Importing-third-party-code as the recommended method of adding this to deps?
At least for the things that gets merged to master, we would like to have the code dumped in a traceable way.
|
@kazuho i rephrased it a bit and added the info with the script. |
|
Thank you for the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternative: add a new file "Extending.md" that starts to collect information on how h2o can be extended