[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cmake build issue #1368

Merged
merged 2 commits into from
Jul 13, 2017
Merged

Fix cmake build issue #1368

merged 2 commits into from
Jul 13, 2017

Conversation

deweerdt
Copy link
Member

This is due to a cmake oddity: when CONFIGURE_COMMAND is not set,
ExternalProject_Add defaults to running cmake with no arguments.

@deweerdt
Fix cmake build issue
ae86d06 
This is due to a cmake oddity: when CONFIGURE_COMMAND is not set,
`ExternalProject_Add` defaults to running cmake with no arguments.
@deweerdt deweerdt mentioned this pull request Jul 12, 2017
Closed
@deweerdt
Copy link
Member Author

There was also an issue with linking to rt on MacOSX. 9f0f976 fixes it. I've added travis support for trusty, precise and macosx builds for h2get, so that won't be an issue for future updates.

@kazuho
Copy link
Member
kazuho commented Jul 13, 2017

This is due to a cmake oddity: when CONFIGURE_COMMAND is not set, ExternalProject_Add defaults to running cmake with no arguments.

Ah! Thank you for the fix.

@kazuho kazuho merged commit 94e5bf3 into h2o:master Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deweerdt @kazuho