[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP/2 priorities fixes #1934

Merged
merged 3 commits into from
Dec 22, 2018
Merged

HTTP/2 priorities fixes #1934

merged 3 commits into from
Dec 22, 2018

Conversation

deweerdt
Copy link
Member

These fixes are a follow up to #1924 . It includes the following fixes:

  • we would leak memory if the relocated stream had no children
  • a relocated stream wouldn't be deactivated, causing invalid reads
  • _queue_node._deficit wasn't correctly carried over from the old stream.

@kazuho
Copy link
Member
kazuho commented Dec 22, 2018

Thank you for the fix! LGTM.

@kazuho kazuho merged commit 19792c8 into h2o:master Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deweerdt @kazuho