[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] try chashmap in cache implementations #29

Closed
wants to merge 4 commits into from
Closed

[WIP] try chashmap in cache implementations #29

wants to merge 4 commits into from

Conversation

epwalsh
Copy link
Collaborator
@epwalsh epwalsh commented Jan 2, 2020

@epwalsh epwalsh changed the title [Experiment] try chashmap in cache implementations [Experimental] try chashmap in cache implementations Jan 2, 2020
@epwalsh epwalsh changed the title [Experimental] try chashmap in cache implementations [WIP] try chashmap in cache implementations Jan 2, 2020
@epwalsh
Copy link
Collaborator Author
epwalsh commented Jan 3, 2020

Benchmarks:

image

@n1t0
Copy link
Member
n1t0 commented Jan 3, 2020

I guess here it gets the locks every time and doesn't just try as we do with RwLock.

@epwalsh
Copy link
Collaborator Author
epwalsh commented Jan 3, 2020

Yea.. I couldn't find a way around that. As is, it definitely doesn't work well for our use case.

@epwalsh epwalsh closed this Jan 3, 2020
@epwalsh epwalsh deleted the chashmap branch January 3, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@epwalsh @n1t0