[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deterministic config to set_seed #29778

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Add deterministic config to set_seed #29778

merged 3 commits into from
Mar 21, 2024

Conversation

muellerzr
Copy link
Contributor

What does this PR do?

Allows for deterministic algorithms to be reproducible. Can come at the cost of things being slower.

Requested in internal slack thread: https://huggingface.slack.com/archives/C038TF8B7UZ/p1711016602277049

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@amyeroberts @Rocketknight1

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Rocketknight1
Rocketknight1 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member
@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! tf.config.experimental.enable_op_determinism() is the right way to do this.

amyeroberts
amyeroberts approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator
@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this so quickly!

@muellerzr muellerzr merged commit 10d232e into main Mar 21, 2024
21 checks passed
@muellerzr muellerzr deleted the muellerzr-deterministic branch March 21, 2024 15:07
itazap pushed a commit that referenced this pull request May 14, 2024
@muellerzr
Add deterministic config to set_seed (#29778)
5a6b789 
* Add deterministic config

* Add note on slowdown

* English fails me again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengomucho tengomucho tengomucho approved these changes

@Rocketknight1 Rocketknight1 Rocketknight1 approved these changes

@amyeroberts amyeroberts amyeroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@muellerzr @HuggingFaceDocBuilderDev @tengomucho @Rocketknight1 @amyeroberts