[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added type hints to TFDeiTModel #22327

Merged
merged 3 commits into from
Mar 23, 2023
Merged

Added type hints to TFDeiTModel #22327

merged 3 commits into from
Mar 23, 2023

Conversation

Batese2001
Copy link
Contributor

What does this PR do?

This pull request adds type hints for modeling_tf_deit.py as outlined in Issue #16059

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@Rocketknight1

@HuggingFaceDocBuilderDev
Copy link
HuggingFaceDocBuilderDev commented Mar 23, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

Rocketknight1
Rocketknight1 approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member
@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@Rocketknight1 Rocketknight1 merged commit aef488c into huggingface:main Mar 23, 2023
raghavanone pushed a commit to raghavanone/transformers that referenced this pull request Apr 5, 2023
@Batese2001 @Rocketknight1 @raghavanone
Added type hints to TFDeiTModel (huggingface#22327)
e5cd789 
* Added type hints to TFDeiTModel

* make style

---------

Co-authored-by: Matt <rocketknight1@gmail.com>
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
@Batese2001 @Rocketknight1 @novice03
Added type hints to TFDeiTModel (huggingface#22327)
47c6d9b 
* Added type hints to TFDeiTModel

* make style

---------

Co-authored-by: Matt <rocketknight1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rocketknight1 Rocketknight1 Rocketknight1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Batese2001 @HuggingFaceDocBuilderDev @Rocketknight1