[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated training.mdx to Korean #22670

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

gabrielwithappy
Copy link
Contributor
@gabrielwithappy gabrielwithappy commented Apr 8, 2023

What does this PR do?

Translated the training.mdx file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Team PseudoLab, may you please review this PR?
@0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

May you please review this PR?
@sgugger, @ArthurZucker, @eunseojo

@HuggingFaceDocBuilderDev
Copy link
HuggingFaceDocBuilderDev commented Apr 9, 2023

The documentation is not available anymore as the PR was closed or merged.

docs/source/ko/training.mdx Outdated Show resolved Hide resolved
@gabrielwithappy gabrielwithappy marked this pull request as ready for review April 12, 2023 15:41
@gabrielwithappy
Copy link
Contributor Author
gabrielwithappy commented Apr 12, 2023

Team PseudoLab, may you please review this PR?
@0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

Copy link
Contributor
@wonhyeongseo wonhyeongseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~L100 preliminary review
Thank you so much for your hard work, @gabrielwithappy 💜

docs/source/ko/autoclass_tutorial.mdx Show resolved Hide resolved
docs/source/ko/training.mdx Outdated Show resolved Hide resolved
docs/source/ko/training.mdx Outdated Show resolved Hide resolved
docs/source/ko/training.mdx Outdated Show resolved Hide resolved
docs/source/ko/training.mdx Outdated Show resolved Hide resolved
docs/source/ko/training.mdx Outdated Show resolved Hide resolved
sim-so

This comment was marked as abuse.

sim-so

This comment was marked as duplicate.

@gabrielwithappy gabrielwithappy force-pushed the ko-training branch 3 times, most recently from efaf6cd to 8f7d10a Compare April 13, 2023 14:09
@gabrielwithappy
Copy link
Contributor Author

fixed review comments :-)
Thank you your kind reivews.
BRs
@HanNayeoniee @sim-so @wonhyeongseo

@gabrielwithappy gabrielwithappy changed the title [WIP]🌐 [i18n-KO] Translated training.mdx to Korean 🌐 [i18n-KO] Translated training.mdx to Korean Apr 13, 2023
@gabrielwithappy
Copy link
Contributor Author

May you please review this PR?
@sgugger, @ArthurZucker, @eunseojo

Copy link
Collaborator
@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@sgugger sgugger merged commit 4def2fe into huggingface:main Apr 13, 2023
@wonhyeongseo wonhyeongseo mentioned this pull request May 2, 2023
5 tasks
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants