[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sneaky torch dependency in TF example #22804

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Fix sneaky torch dependency in TF example #22804

merged 1 commit into from
Apr 17, 2023

Conversation

Rocketknight1
Copy link
Member

Thanks to @muellerzr for uncovering this one - the TF image classification example sneakily depended on torch because it used MODEL_FOR_IMAGE_CLASSIFICATION_MAPPING (which is a dummy if torch is unavailable) and called one of the TrainingArguments properties that requires torch. Made a quick PR to fix it!

@HuggingFaceDocBuilderDev
Copy link
HuggingFaceDocBuilderDev commented Apr 17, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

amyeroberts
amyeroberts approved these changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator
@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@Rocketknight1 Rocketknight1 merged commit 2237127 into main Apr 17, 2023
@Rocketknight1 Rocketknight1 deleted the fix_tf_image_classification_example branch April 17, 2023 15:11
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
@Rocketknight1 @novice03
Fix sneaky torch dependency in TF example (huggingface#22804)
a9f59cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyeroberts amyeroberts amyeroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rocketknight1 @HuggingFaceDocBuilderDev @amyeroberts