-
Notifications
You must be signed in to change notification settings - Fork 26.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Past CI not running against the latest main
#22823
Conversation
@@ -30,6 +30,7 @@ jobs: | |||
with: | |||
framework: pytorch | |||
version: "1.13" | |||
sha: ${{ github.sha }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow file self-past.yml
, when used in a workflow_call
, accept some inputs including sha
:
transformers/.github/workflows/self-past.yml
Lines 10 to 22 in 0670ccb
workflow_call: | |
inputs: | |
framework: | |
required: true | |
type: string | |
version: | |
required: true | |
type: string | |
# Use this to control the commit to test against | |
sha: | |
default: 'main' | |
required: false | |
type: string |
Previously, the Past CI is launched manually by @ydshieh, and the goal is to targe a fixed & specific commit for some runs (so we can compare the results before/after the fixes). At that time, it was launched only once during a few months.
Right now, we run it twice per week, see #22393, it makes more sense to run the CI against latest main
. Otherwise, the reports of the (automatically triggered) runs will contain failures that have been fixed on main
and hard to understand at the 1st galance.
@@ -40,6 +41,7 @@ jobs: | |||
with: | |||
framework: pytorch | |||
version: "1.12" | |||
sha: ${{ github.sha }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pass the commit sha of the triggered event to past workflow file.
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
fix Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
What does this PR do?
Fix Past CI not running against the latest
main
. See comment in the changes.