[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Past CI not running against the latest main #22823

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

ydshieh
Copy link
Collaborator
@ydshieh ydshieh commented Apr 18, 2023

What does this PR do?

Fix Past CI not running against the latest main. See comment in the changes.

@@ -30,6 +30,7 @@ jobs:
with:
framework: pytorch
version: "1.13"
sha: ${{ github.sha }}
Copy link
Collaborator Author
@ydshieh ydshieh Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow file self-past.yml, when used in a workflow_call, accept some inputs including sha:

workflow_call:
inputs:
framework:
required: true
type: string
version:
required: true
type: string
# Use this to control the commit to test against
sha:
default: 'main'
required: false
type: string

Previously, the Past CI is launched manually by @ydshieh, and the goal is to targe a fixed & specific commit for some runs (so we can compare the results before/after the fixes). At that time, it was launched only once during a few months.

Right now, we run it twice per week, see #22393, it makes more sense to run the CI against latest main. Otherwise, the reports of the (automatically triggered) runs will contain failures that have been fixed on main and hard to understand at the 1st galance.

@@ -40,6 +41,7 @@ jobs:
with:
framework: pytorch
version: "1.12"
sha: ${{ github.sha }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass the commit sha of the triggered event to past workflow file.

@ydshieh ydshieh requested a review from sgugger April 18, 2023 09:07
@HuggingFaceDocBuilderDev
Copy link
HuggingFaceDocBuilderDev commented Apr 18, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator
@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ydshieh ydshieh merged commit 1ebc1de into main Apr 18, 2023
@ydshieh ydshieh deleted the fix_future_past_ci branch April 18, 2023 13:41
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants