[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix SpeechT5 doc comments #22854

Merged
merged 1 commit into from
Apr 19, 2023
Merged

fix SpeechT5 doc comments #22854

merged 1 commit into from
Apr 19, 2023

Conversation

hollance
Copy link
Contributor

What does this PR do?

Forgot to run the documentation tests on the SpeechT5 TTS changes.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@hollance hollance requested a review from ydshieh April 19, 2023 09:33
@HuggingFaceDocBuilderDev
Copy link
HuggingFaceDocBuilderDev commented Apr 19, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@ydshieh ydshieh self-assigned this Apr 19, 2023
ydshieh
ydshieh approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator
@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Works also on CI runners. Thank you for taking care of this before I tag you on Slack @hollance ❤️

@ydshieh ydshieh merged commit c582e8a into huggingface:main Apr 19, 2023
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
@hollance @novice03
fix SpeechT5 doc comments (huggingface#22854)
89fcfd2 
fix doc comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydshieh ydshieh ydshieh approved these changes

Assignees

@ydshieh ydshieh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hollance @HuggingFaceDocBuilderDev @ydshieh