[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change schedule CI time #22884

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Change schedule CI time #22884

merged 2 commits into from
Apr 20, 2023

Conversation

ydshieh
Copy link
Collaborator
@ydshieh ydshieh commented Apr 20, 2023

What does this PR do?

This PR changes the test CI to be scheduled 2 hours after the image build CI.

Despite #22859 changed to use accelerate@main, the last DeepSpeed CI docker image still has accelerate==0.18.0. This is because that image build takes ~1h30m to finish, but the test CI is scheduled (only) 1 hour after the image build CI.

Although from the next run, the schedule test CI will start to use accelerate@main, there will be a gap - i.e. it will use the accelerate@main one day before the current main.

@@ -11,7 +11,7 @@ on:
required: true
type: string
schedule:
- cron: "0 1 * * *"
- cron: "17 0 * * *"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 17 (which is the scheduled minute in an hour) is to make the actions being triggered as close to the specified time as possible.

From doc :

The schedule event can be delayed during periods of high loads of GitHub Actions workflow runs. High load times include the start of every hour. If the load is sufficiently high enough, some queued jobs may be dropped. To decrease the chance of delay, schedule your workflow to run at a different time of the hour.

@HuggingFaceDocBuilderDev
Copy link
HuggingFaceDocBuilderDev commented Apr 20, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator
@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

.github/workflows/self-nightly-past-ci-caller.yml Outdated Show resolved Hide resolved
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@ydshieh ydshieh merged commit aa43167 into main Apr 20, 2023
@ydshieh ydshieh deleted the fix_timing branch April 20, 2023 12:01
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
* fix

* Update .github/workflows/self-nightly-past-ci-caller.yml

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants