-
Notifications
You must be signed in to change notification settings - Fork 26.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change schedule CI time #22884
Change schedule CI time #22884
Conversation
@@ -11,7 +11,7 @@ on: | |||
required: true | |||
type: string | |||
schedule: | |||
- cron: "0 1 * * *" | |||
- cron: "17 0 * * *" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 17
(which is the scheduled minute in an hour) is to make the actions being triggered as close to the specified time as possible.
From doc :
The schedule event can be delayed during periods of high loads of GitHub Actions workflow runs. High load times include the start of every hour. If the load is sufficiently high enough, some queued jobs may be dropped. To decrease the chance of delay, schedule your workflow to run at a different time of the hour.
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating!
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
* fix * Update .github/workflows/self-nightly-past-ci-caller.yml Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com> --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com> Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
What does this PR do?
This PR changes the test CI to be scheduled 2 hours after the image build CI.
Despite #22859 changed to use
accelerate@main
, the last DeepSpeed CI docker image still hasaccelerate==0.18.0
. This is because that image build takes ~1h30m to finish, but the test CI is scheduled (only) 1 hour after the image build CI.Although from the next run, the schedule test CI will start to use
accelerate@main
, there will be a gap - i.e. it will use theaccelerate@main
one day before the currentmain
.