[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sam ONNX exportable #22915

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Conversation

fxmarty
Copy link
Contributor
@fxmarty fxmarty commented Apr 21, 2023

As per title, would be great to have this PR on the next release so that we can support the ONNX export (see huggingface/optimum#995). This piece is the only blocking one.

@HuggingFaceDocBuilderDev
Copy link
HuggingFaceDocBuilderDev commented Apr 21, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator
@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Should you also add an ONXX config and enable the CI tests ? (not sure maybe tracing will work)

src/transformers/models/sam/modeling_sam.py Show resolved Hide resolved
@fxmarty
Copy link
Contributor Author
fxmarty commented Apr 21, 2023

@ArthurZucker The PR is here: huggingface/optimum#995

Copy link
Collaborator
@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

src/transformers/models/sam/modeling_sam.py Outdated Show resolved Hide resolved
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
@sgugger sgugger merged commit 7544455 into huggingface:main Apr 21, 2023
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
* fix code not exportable

* fix

* Update src/transformers/models/sam/modeling_sam.py

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

---------

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants