[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing tokenization test [electra] #22997

Merged
merged 3 commits into from
May 17, 2023
Merged

Conversation

IMvision12
Copy link
Contributor
@IMvision12 IMvision12 commented Apr 25, 2023

What does this PR do?

Added tokenization test for electra

@HuggingFaceDocBuilderDev
Copy link
HuggingFaceDocBuilderDev commented Apr 25, 2023

The documentation is not available anymore as the PR was closed or merged.

@sgugger
Copy link
Collaborator
sgugger commented Apr 25, 2023

Thanks a lot for your PR! @ArthurZucker could you review?

@IMvision12
Copy link
Contributor Author

@sgugger Any updates, is there something wrong?

Copy link
Collaborator
@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, Arthur didn't get to review your PR before leaving for a long vacation. Just one nit and this should be good to merge!

tests/models/electra/test_tokenization_electra.py Outdated Show resolved Hide resolved
IMvision12 and others added 2 commits May 17, 2023 19:06
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
@IMvision12
Copy link
Contributor Author

@sgugger Done!!

@IMvision12 IMvision12 requested a review from sgugger May 17, 2023 14:02
@sgugger sgugger merged commit ebb649a into huggingface:main May 17, 2023
@IMvision12 IMvision12 deleted the electra branch May 17, 2023 14:52
@ArthurZucker
Copy link
Collaborator

Thanks for contributing 🔥

sheonhan pushed a commit to sheonhan/transformers that referenced this pull request Jun 1, 2023
* Create test_tokenization_electra.py

* Update tests/models/electra/test_tokenization_electra.py

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

---------

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
* Create test_tokenization_electra.py

* Update tests/models/electra/test_tokenization_electra.py

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

---------

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
* Create test_tokenization_electra.py

* Update tests/models/electra/test_tokenization_electra.py

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

---------

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants