Fix issue introduced in PR #23163 #23363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
May 15, 2023
| @@ -234,7 +234,7 @@ def is_torch_support_available(self) -> bool: | |||
| if is_torch_available(): | |||
| from transformers.utils import get_torch_version | |||
|
|
|||
| return get_torch_version() >= self.torch_onnx_minimum_version | |||
| return version.parse(get_torch_version()) >= self.torch_onnx_minimum_version | |||
There was a problem hiding this comment.
type Error without this PR
|
The documentation is not available anymore as the PR was closed or merged. |
|
FYI, after #23163, I will fix this in a separate PR. |
sheonhan
pushed a commit
to sheonhan/transformers
that referenced
this pull request
Jun 1, 2023
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix issue introduced in PR #23163.
The previous
torch_versionis removed (which is not a string but aversiontype), andget_torch_version()is introduced and used (which is a string). In some places, it is compared againstself.torch_onnx_minimum_versionwhich is a string, and we know get on CITypeError: '<' not supported between instances of 'str' and 'Version'.This PR fixes this problem and avoid the > 1000 test failures.
(cc. @apbard FYI)