[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parallel mode check #23409

Merged
merged 6 commits into from
May 19, 2023
Merged

Fix parallel mode check #23409

merged 6 commits into from
May 19, 2023

Conversation

muellerzr
Copy link
Contributor

What does this PR do?

Fixes a check that relies on distributed_state when it might not be there

Fixes # (issue)

Should fix #23390

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sgugger

@muellerzr muellerzr requested a review from sgugger May 16, 2023 16:42
@HuggingFaceDocBuilderDev
Copy link
HuggingFaceDocBuilderDev commented May 16, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger reviewed May 16, 2023
View reviewed changes
Copy link
Collaborator
@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused on how this fixes the bug for SageMaker dp, as we can only be in this path if Sagemaker mp is true (so might be better to do an elif instead of the if and remove the new checj?)

@muellerzr muellerzr requested a review from sgugger May 19, 2023 16:10
@muellerzr muellerzr changed the title Fix sagemaker Fix parallel mode check May 19, 2023
@muellerzr muellerzr merged commit b455ad0 into main May 19, 2023
@muellerzr muellerzr deleted the muellerzr-fix-sagemaker branch May 19, 2023 16:44
@muellerzr muellerzr restored the muellerzr-fix-sagemaker branch May 19, 2023 16:44
sheonhan pushed a commit to sheonhan/transformers that referenced this pull request Jun 1, 2023
@muellerzr @sheonhan
Fix parallel mode check (huggingface#23409)
e47c297 
* Fix sagemaker/distributed state

* Fix correctly

* Bring back -1

* Bring back local rank for distributed check

* better version

* Cleanest option
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
@muellerzr @gojiteji
Fix parallel mode check (huggingface#23409)
bfc6a36 
* Fix sagemaker/distributed state

* Fix correctly

* Bring back -1

* Bring back local rank for distributed check

* better version

* Cleanest option
@muellerzr muellerzr deleted the muellerzr-fix-sagemaker branch June 5, 2023 18:08
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
@muellerzr @novice03
Fix parallel mode check (huggingface#23409)
26ff15d 
* Fix sagemaker/distributed state

* Fix correctly

* Bring back -1

* Bring back local rank for distributed check

* better version

* Cleanest option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Sagemaker] sagemaker distributed features in Trainer broken since Transformers 4.29
3 participants
@muellerzr @HuggingFaceDocBuilderDev @sgugger