[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 [i18n-KO] Translated language-modeling.mdx #23969

Merged
merged 6 commits into from
Jun 6, 2023
Merged

🌐 [i18n-KO] Translated language-modeling.mdx #23969

merged 6 commits into from
Jun 6, 2023

Conversation

wonhyeongseo
Copy link
Contributor
@wonhyeongseo wonhyeongseo commented Jun 3, 2023 •
edited
Loading

What does this PR do?

Translated the language-modeling.mdx file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team PseudoLab, may you please review this PR? @0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@sgugger, @ArthurZucker, @eunseojo May you please review this PR?

@wonhyeongseo wonhyeongseo changed the title 🌐 [i18n-KO] Translated `language-modeling.mdx 🌐 [i18n-KO] Translated language-modeling.mdx Jun 3, 2023
@wonhyeongseo wonhyeongseo changed the title 🌐 [i18n-KO] Translated language-modeling.mdx 🌐 [i18n-KO] Translated language-modeling.mdx Jun 3, 2023
@HuggingFaceDocBuilderDev
Copy link
HuggingFaceDocBuilderDev commented Jun 3, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sim-so
sim-so suggested changes Jun 3, 2023
View reviewed changes
Copy link
Contributor
@sim-so sim-so left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한 번에 많은 문서를 번역하시느라 고생 많으셨어요!
glossary 관련 의견 몇 가지를 전달 드려요.

docs/source/ko/_toctree.yml Outdated Show resolved Hide resolved
docs/source/ko/tasks/language_modeling.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/language_modeling.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/language_modeling.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/language_modeling.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/language_modeling.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/language_modeling.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/language_modeling.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/language_modeling.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/language_modeling.mdx Outdated Show resolved Hide resolved
wonhyeongseo
wonhyeongseo commented Jun 6, 2023
View reviewed changes
Copy link
Contributor Author
@wonhyeongseo wonhyeongseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sim-so 님 감사합니다!

docs/source/ko/_toctree.yml Outdated Show resolved Hide resolved
@wonhyeongseo @sim-so
fix: resolve suggestions
f1bea6d 
Co-authored-by: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
@wonhyeongseo wonhyeongseo marked this pull request as ready for review June 6, 2023 04:04
@wonhyeongseo
Copy link
Contributor Author

@sgugger, @ArthurZucker, @eunseojo May you please review this PR?

ArthurZucker
ArthurZucker approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator
@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go! Thanks for the contribution 😉

@ArthurZucker ArthurZucker requested a review from sgugger June 6, 2023 08:39
@sgugger sgugger merged commit c938597 into huggingface:main Jun 6, 2023
@wonhyeongseo wonhyeongseo deleted the ko-language-modelling2 branch June 7, 2023 02:49
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
@wonhyeongseo @sim-so @novice03
🌐 [i18n-KO] Translated language-modeling.mdx (huggingface#23969)
d0d49d4 
* docs: ko: `language_modeling.mdx`

* feat: nmt draft

* fix: manual edits

* fix: add inline toc

* fix: typo in toc_tree.yml

* fix: resolve suggestions

Co-authored-by: Sohyun Sim <96299403+sim-so@users.noreply.github.com>

---------

Co-authored-by: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sim-so sim-so sim-so requested changes

@ArthurZucker ArthurZucker ArthurZucker approved these changes

@sgugger sgugger Awaiting requested review from sgugger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wonhyeongseo @HuggingFaceDocBuilderDev @ArthurZucker @sim-so @sgugger