Feat/amm arb oracle #3466
Closed
Feat/amm arb oracle #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmingbot into feat/amm_arb_oracle Rebase with origin/development
PtrckM
reviewed
Jun 1, 2021
Nullably
suggested changes
Jun 1, 2021
| @@ -99,6 +99,16 @@ def prices(self) -> Dict[str, Decimal]: | |||
| """ | |||
| return self._prices.copy() | |||
|
|
|||
| def rate_for_tokens(self, base_token: str, quote_token: str) -> Decimal: | |||
There was a problem hiding this comment.
This is not a quite clear function name, maybe rate_for_trading_pair?
| self._quote_eth_rate_fetch_loop_task = safe_ensure_future(self.quote_in_eth_rate_fetch_loop()) | ||
| self._quote_eth_rate_fetch_loop_task = safe_ensure_future(self.quote_in_eth_rate_fetch_loop()) | ||
| if self._use_oracle_conversion_rate: | ||
| RateOracle.get_instance().start() |
There was a problem hiding this comment.
Rate Oracle is started on start_check in start_command, you don't need to start it here. On the start_check, it also confirms conversion rate with a user before starting, this is to prevent input error.
| @@ -121,4 +121,11 @@ def order_amount_prompt() -> str: | |||
| default=False, | |||
| validator=validate_bool, | |||
| type_str="bool"), | |||
| "use_oracle_conversion_rate": ConfigVar( | |||
There was a problem hiding this comment.
You'll need to set rate_oracle_pairs global setting variable, you can see Arbitrage config map for an example.
|
Nice to see you are adding pydocs :) |
|
I close this PR because it has been replaced with https://github.com/CoinAlpha/hummingbot/pull/3492 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change in amm_arb strategy to make it posible to use rate oracle to look for rates.
There is a new parameter that enables the use of the oracle to get the price of quote tokens in ETH.
Also the status message was extended to include the information about the quote rates in ETH, that shows the user if the strategy is using the oracle or not.
https://app.zenhub.com/workspaces/hummingbot-5f340755c5e17300167a8f30/issues/coinalpha/hummingbot/3216
https://github.com/CoinAlpha/hummingbot/issues/3216