[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possibility to use rate oracle as provider of rates to calculate … #3492

Merged
merged 14 commits into from
Jun 9, 2021
Merged

Add possibility to use rate oracle as provider of rates to calculate … #3492

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ddd760b
Add possibility to use rate oracle as provider of rates to calculate …
aarmoa Jun 3, 2021
1818fcd
Add possibility to use rate oracle as provider of rates to calculate …
aarmoa Jun 3, 2021
6a7e4e5
Merge branch 'feat/add_rate_oracle_to_amm_arb' of https://github.com/…
aarmoa Jun 3, 2021
9122e32
Add conversion in order calculation to consider different orders of m…
aarmoa Jun 4, 2021
824ca57
Merge branch 'development' into feat/add_rate_oracle_to_amm_arb
aarmoa Jun 4, 2021
48d61d8
Add possibility to use rate oracle as provider of rates to calculate …
aarmoa Jun 3, 2021
794ef26
Add conversion in order calculation to consider different orders of m…
aarmoa Jun 4, 2021
95acb75
Merge branch 'feat/add_rate_oracle_to_amm_arb' of https://github.com/…
aarmoa Jun 4, 2021
9ce6269
Merge branch 'development' into feat/add_rate_oracle_to_amm_arb
aarmoa Jun 7, 2021
3e58421
Merge branch 'development' of https://github.com/CoinAlpha/hummingbot…
aarmoa Jun 8, 2021
bd1e5cc
Add warning log when profitability can't be calculated due to missing…
aarmoa Jun 8, 2021
161298f
Change profitability status description to use the correct rate sourc…
aarmoa Jun 8, 2021
6292961
Add timeout to test_web_app_response because it is breaking in Github…
aarmoa Jun 8, 2021
fbfa2e1
(feat) remove unintended code update
Nullably Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change profitability status description to use the correct rate sourc… 
…e provider
  • Loading branch information
@aarmoa
aarmoa committed Jun 8, 2021
commit 161298f7813bbca3bb29f3323f40cff2ac9c41c4
1 change: 0 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
.ONESHELL:

test:
nosetests -d -v test/test*.py
find test/hummingbot/ -iname "test_*.py" | xargs nosetests -v -d

coverage:
Expand Down
4 changes: 3 additions & 1 deletion hummingbot/strategy/amm_arb/amm_arb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,9 @@ def short_proposal_msg(self, arb_proposal: List[ArbProposal], indented: bool = T
for proposal in arb_proposal:
side1 = "buy" if proposal.first_side.is_buy else "sell"
side2 = "buy" if proposal.second_side.is_buy else "sell"
profit_pct = proposal.profit_pct(True, first_side_quote_eth_rate=self._market_1_quote_eth_rate,
profit_pct = proposal.profit_pct(True,
rate_source=self._rate_source,
first_side_quote_eth_rate=self._market_1_quote_eth_rate,
second_side_quote_eth_rate = self._market_2_quote_eth_rate)
lines.append(f"{' ' if indented else ''}{side1} at {proposal.first_side.market_info.market.display_name}"
f", {side2} at {proposal.second_side.market_info.market.display_name}: "
Expand Down