[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ temp remove code coverage requirement #3536

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

Nullably
Copy link
Contributor
@Nullably Nullably commented Jun 8, 2021

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Unit test code coverage requirement was introduced too late in the development cycle, just a few days before release date. This should be done at the beginning for the release.
  • Set the requirements to 0 for now, we'll set it back to the required agreed level at the start of the next release.

Copy link
Contributor
@dennisocana dennisocana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dennisocana dennisocana merged commit 49c101c into development Jun 8, 2021
@dennisocana dennisocana deleted the fix/remove_code_coverage_requirment branch June 8, 2021 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants