[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FTX from the codebase #5893

Merged
merged 5 commits into from
Nov 21, 2022
Merged

Remove FTX from the codebase #5893

merged 5 commits into from
Nov 21, 2022

Conversation

cardosofede
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Remove FTX connector from the codebase as it's not more usable.

Tests performed by the developer:

Tips for QA testing:
Run any strategy

@rapcmia rapcmia linked an issue Nov 17, 2022 that may be closed by this pull request
FTX- Error in requesting exchange info #5883
Closed
arnelhbot
arnelhbot previously approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor
@arnelhbot arnelhbot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test performed:

  • Installation tests for client on source successful
  • Setup client and created password successfully
  • Called connect to confirm ftx was removed from the list of connectors successfully
  • Called connect ftx to verify to be invalid choice
  • Failed to create any strategy with Ftx as connector is an Invalid exchange
  • Ftx has been confirmed to be an invalid entry during testing

@nikspz
Copy link
Contributor
nikspz commented Nov 17, 2022 •
edited
Loading
  • latest commit [50af3b4](50af3b4)
    • Test performed:
      • Installation tests for client
        • source build successful
        • built docker image successfully
      • Source Build:
        • Setup client and created password successfully
        • ftx was removed from the list of connectors (on connect command) successfully
        • Called connect ftx to verify to be invalid choice
        • Ftx confirmed as invalid entry during testing
        • Failed to create any strategy with Ftx as connector
      • Docker build:
        • There’re warning messages Cannot find corresponding config to key ftx_...._ in template on docker image creation/start
        • Called connect ftx to verify to be invalid choice
        • Failed to create any strategy with Ftx as connector

@cardosofede There're errors/warning messages on docker image creation:
Cannot find corresponding config to key ftx ..... in template
I guess if coming from ....ftxPR5893\hummingbot\templates\conf_fee_overrides_TEMPLATE.yml

Steps:
Clone and install branch
Manually create docker image
run ./create.sh to create new docker instance

Actual:
There're warning message on new docker instance creation

18:37:52 - root - Cannot find corresponding config to key ftx_buy_percent_fee_deducted_from_returns in template.
18:37:52 - root - Cannot find corresponding config to key ftx_maker_fixed_fees in template.
18:37:52 - root - Cannot find corresponding config to key ftx_maker_percent_fee in template.
18:37:52 - root - Cannot find corresponding config to key ftx_percent_fee_token in template.
18:37:52 - root - Cannot find corresponding config to key ftx_taker_fixed_fees in template.
18:37:52 - root - Cannot find corresponding config to key ftx_taker_percent_fee in template.

image

I guess it's coming from ....ftxPR5893\hummingbot\templates\conf_fee_overrides_TEMPLATE.yml
image

nikspz
nikspz approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor
@nikspz nikspz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test performed:

  • Installation tests for client
  • source build successful
  • built docker image successfully
  • Source Build:
    • Setup client and created password successfully
    • ftx was removed from the list of connectors (on connect command) successfully
    • Called connect ftx to verify to be invalid choice
    • Ftx confirmed as invalid entry during testing
    • Failed to create any strategy with Ftx as connector
  • Docker build:
    • no redundant warning messages showed
    • Called connect ftx to verify to be invalid choice
    • Failed to create any strategy with Ftx as connector

@JeremyKono JeremyKono merged commit 2e70fa2 into hummingbot:development Nov 21, 2022
This was referenced Nov 23, 2022
Closed
Closed
@fengtality fengtality mentioned this pull request Dec 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeremyKono JeremyKono JeremyKono approved these changes

@nikspz nikspz nikspz approved these changes

@arnelhbot arnelhbot arnelhbot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FTX- Error in requesting exchange info
4 participants
@cardosofede @nikspz @JeremyKono @arnelhbot