-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) modify start.sh command to use quickstart arguments #6566
Conversation
references issue - #6564
Note: you need to set up env variables, simple password/strategy.yml string will fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! good job @david-hummingbot
did you tried to pass the arguments?
Fresh installation. commit c52846e
Actual: bot failed to start Expected: bot starts and requests for password |
Deleted all previously set variables and retested:
Steps:
Actual: Expected: |
- exit code 1 for invalid password - exit code 2 for invalid config file
reverted change to using exit codes and instead start command will check the error logs and output the result in the terminal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- test performed:
- Cloned and installed
- set up password
a
- ./start -p a - success
- ./start - success
- created paper.yml
- ./start -p a -f paper.yml - success
- deleted password verification
- set new
Pa11
password - ./start -p Pa11 success
- ./start -p Pa1123 - incorrect password warning message showing
- ./start -p Pa11 -p nostrategy.yml - invalid filename provided warning
references issue - #6564
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Tests performed by the developer:
./start
command./start
command passing the-p
password parameter (only works using environment variables)Tips for QA testing: