[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/position executor db table #6644

Merged
merged 17 commits into from
Nov 16, 2023
Merged

Feat/position executor db table #6644

merged 17 commits into from
Nov 16, 2023

Conversation

cardosofede
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Add position executors table and refactor the logic of the executor handler to store the executors in the database instead of the csv.

Tests performed by the developer:

Tips for QA testing:

cardosofede and others added 17 commits November 7, 2023 22:12
@cardosofede
(feat) add exchange and trading pair in base controller for simplicity
9d38170
@cardosofede
(feat) log the name of the enums
b21890a
@cardosofede
(feat) make markets recorder singleton
aa9af9f
@cardosofede
(feat) create tests to store and get executors
8c2bae8
@cardosofede
(feat) add markets recorder functionality to store and get executors
89fdbf2
@cardosofede
(feat) create position executors model
5f921f7
@cardosofede
(feat) remove config from controller
aa3c68e
@cardosofede
(feat) improve data methods
b54142b
@cardosofede
(feat) transition csv files to database
b632d6e
@cardosofede
Merge branch 'development' into feat/position_executor_db_table
fa8a0e4
@cardosofede
(feat) adapt test for executor handler base
9b2c410
@cardosofede
(feat) adapt test for controller base
6cbc3eb
@cardosofede
(feat) change test for timestamp
40b20ff
@cardosofede
(feat) remove test
351ae4a
@cardosofede
(feat) add test again
658c9c3
@cardosofede
(feat) refactor mocks
2b4b5d4
@cardosofede
(feat) add complete mock for to json
47424d2
@rapcmia
Copy link
Contributor
rapcmia commented Nov 14, 2023 •
edited
Loading
  • Ran tests on source
  • Compare data between old .csv to sqlite
    • Additional Id, order_levels and controller_name
    • Compare data when using different markets
      • When initially started with GAS-USDT, it was recorded on the sqlite
      • Changed the market to BAKE-USDT, with recorded trade data on .csv file however not on sqlite
        image
        • Compare data when using dmanv3, same results

Steps to reproduce:

  • Setup any script
  • Start the script and run til satisfied with the trades then stop the bot
  • Check .csv and sqlite file and compare

Archive.zip

Pending:

  • Run tests on docker version
  • Run scripts that support multiple markets

@rapcmia
Copy link
Contributor
rapcmia commented Nov 15, 2023

Changed the market to BAKE-USDT, with recorded trade data on .csv file however not on sqlite

  • Run long term bot today and on a script with multiple markets and order level of 7
  • Upon checking the sqlite file again, its recording multiple markets.
    image
    • Database table names are complete on sqlite

Pending:

  • Atm checking docker build

rapcmia
rapcmia approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor
@rapcmia rapcmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Setup dmanv3 script and run multiple market pairs with order levels
  • Compare data from old dmanv3 csv files vs PositionExecutoron sqlite
  • Added names are Id, order_levels and controller_name
  • Check timestamp coverted readable date, ok
  • Run tests on both source and docker

@cardosofede cardosofede merged commit 08af81f into hummingbot:development Nov 16, 2023
2 checks passed
@rapcmia rapcmia mentioned this pull request Nov 20, 2023
Merged
2 tasks
@nikspz nikspz mentioned this pull request Nov 23, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rapcmia rapcmia rapcmia approved these changes

@nikspz nikspz Awaiting requested review from nikspz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cardosofede @rapcmia