Fix/hck 4778 hackolade assignment examples are always genera #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c041231.
taras-dubyk
reviewed
Mar 19, 2024
| @@ -346,9 +346,45 @@ function getDiscriminator(discriminator) { | |||
| }; | |||
| } | |||
|
|
|||
| function correctType(value, type) { | |||
There was a problem hiding this comment.
I would rename it to something like parseExampleValueByDataType to make it not look like it's related to the schema types handled in this file.
Also, it's better to place it in another file, you may create a new one if required, exampleDataHelper or smth like this.
taras-dubyk
approved these changes
Mar 20, 2024
taras-dubyk
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dynamicFieldfor handle input value accordingly to field type