-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Make another CircleImageView extending AppCompatImageView #105
Comments
It's work only on Android 5.0 and after. Before 5.0 we get a crash during inflate :
(with v2.0.0 release) After debuging it appear that all How is this possible ? |
+1 Tint isn't applied to images. Tested on Nexus 5, 6.0.1. |
The NPE is fixed, thanks to @colinrtwhite. I'm not gonna make CirlcleImageView extend AppCompatImageView and with that depend on the appcompat library though, as that would needlessly bloat this library. |
Good point - I didn't think about the bloat. However, does that mean image tint on pre-Lollipop will not work? Also, when do you plan to make the next release? Thanks. |
|
Could you release include this fix ? |
as above talks, image tint on after-Lollipop should work. However it doesn't work on android-m... tint attribute is included in not only AppCompatImageView but also ImageView. Why is this? Please have an answer. |
@jy617lee you misread that, tint is not supported at all. |
android:tint
isn't working in xml, crashes the app. I suppose this is achievable using AppCompatImageViewThe text was updated successfully, but these errors were encountered: