[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix google crawler #84

Closed
hongzio opened this issue Oct 6, 2020 · 3 comments
Closed

Fix google crawler #84

hongzio opened this issue Oct 6, 2020 · 3 comments

Comments

@hongzio
Copy link
hongzio commented Oct 6, 2020

On October 6th, a new attribute (sideChannel) has been added to the response.
Like #74, change site-packages/icrawler/builtin/google.py:154 to the following:

            txt = re.sub(r"^AF_initDataCallback\({.*key: 'ds:(\d)'.+data:(.+), sideChannel: {.*}}\);?$",
                         "\\2", txt, 0, re.DOTALL)
@geriskenderi
Copy link

I can confirm that this fixed google image search issues for me, thanks @hongzio

ZhiyuanChen added a commit to ZhiyuanChen/icrawler that referenced this issue Oct 25, 2020
@ZhiyuanChen
fixes hellock#74 with hellock#84
de762cf
hellock added a commit that referenced this issue Oct 26, 2020
@hellock
Merge pull request #86 from ZhiyuanChen/patch-1
16d3619 
fixes #74 with #84
@ZhiyuanChen
Copy link
Collaborator

Thank you for pointing out!

This was referenced Oct 26, 2020
Closed
Closed
@ZhiyuanChen ZhiyuanChen mentioned this issue Nov 19, 2020
Closed
@ProfPMJ
Copy link
ProfPMJ commented Jan 12, 2021

This has solved the problem for me, but pip is still downloading the old version (even though it says it's version 0.6.3).

Is that something you can update?

@ZhiyuanChen ZhiyuanChen mentioned this issue Jan 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hongzio @geriskenderi @ZhiyuanChen @ProfPMJ