[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch products from REST API #226

Closed
himanshusharma89 opened this issue May 5, 2021 · 3 comments 路 Fixed by #227
Closed

Fetch products from REST API #226

himanshusharma89 opened this issue May 5, 2021 · 3 comments 路 Fixed by #227
Assignees
@SapinderSingh
Labels
GSSOC21 Issues created for GSSOC'21 Level2 medium gssoc issue

Comments

@himanshusharma89
Copy link
Owner

Discussion 馃棧

Currently, we are fetching the hard-coded products, now you need to fetch the products using a REST API.

Context

Use this API: https://himanshusharma89-api.herokuapp.com/api/relic_bazaar/products
@himanshusharma89 himanshusharma89 added the Level2 medium gssoc issue label May 5, 2021
@himanshusharma89 himanshusharma89 changed the title Fetch products from API Fetch products from REST API May 5, 2021
@github-actions github-actions bot added the GSSOC21 Issues created for GSSOC'21 label May 5, 2021
@himanshusharma89 himanshusharma89 pinned this issue May 5, 2021
@SapinderSingh
Copy link
Contributor

@himanshusharma89 I can work on this issue

@SapinderSingh
Copy link
Contributor

@himanshusharma89 Do I only have to create a method to fetch the products using http ? Or do I have to use it also ? Because, there is no image Url and no height values in the json data.

@himanshusharma89
Copy link
Owner Author

@SapinderSingh Fetch the data, create a factory constructor in the products model, pass the data, and later use it. You can use a check for an image and use an asset if it is empty or the size isn't greater than 1.

@SapinderSingh SapinderSingh mentioned this issue May 6, 2021
Merged
5 tasks
himanshusharma89 pushed a commit that referenced this issue May 6, 2021
@SapinderSingh
Fixes #226 (#227)
25fd006 
* Fixes #226

* #Fixes 226. Made required changes.
@himanshusharma89 himanshusharma89 unpinned this issue May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SapinderSingh SapinderSingh

Labels
GSSOC21 Issues created for GSSOC'21 Level2 medium gssoc issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #226
2 participants
@SapinderSingh @himanshusharma89