[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to null safety #251

Closed
himanshusharma89 opened this issue Sep 26, 2021 · 5 comments 路 Fixed by #252
Closed

Migrate to null safety #251

himanshusharma89 opened this issue Sep 26, 2021 · 5 comments 路 Fixed by #252
Assignees
@ShrutiJ-01
Labels
hacktoberfest

Comments

@himanshusharma89
Copy link
Owner

Discussion 馃棧

Migrate the whole project to null safety.

Context

Follow this guide to know about the migration: https://dart.dev/null-safety/migration-guide
@ShrutiJ-01
Copy link
Contributor

@himanshusharma89 I'd like to work on this!

@himanshusharma89
Copy link
Owner Author

Sure @ShrutiJ-01. Also if you face some dependency issues do raise a new issue for that.

@ShrutiJ-01
Copy link
Contributor

Hey @himanshusharma89 the version of packages "geocoder" and "modal_progress_hud" which the project are using are not null safe. There is a null safe version of "modal_progress_hud" and similar alternative for geocoder I've found. May I add these dependencies in the pubspec instead of old ones?

@himanshusharma89
Copy link
Owner Author

Sure @ShrutiJ-01

ShrutiJ-01 added a commit to ShrutiJ-01/relic_bazaar that referenced this issue Oct 25, 2021
@ShrutiJ-01
Migrated Project to null safety.
c2d0ee8 
Changed packages geocoder and modal_progress_hud to their null safe versions flutter_geocoder and modal_progress_hud_nsn in pubspec.yaml. Added null check operators and replaced deprecated methods with new ones.In widget_test.dart, added AdState provider to the 'ProductPage displays text and image correctly' test.

Resolves himanshusharma89#251
@ShrutiJ-01 ShrutiJ-01 mentioned this issue Oct 25, 2021
Merged
5 tasks
@ShrutiJ-01
Copy link
Contributor

Hey @himanshusharma89 , I've opened a PR. Please let me know if any changes are required!

himanshusharma89 pushed a commit that referenced this issue Oct 26, 2021
@ShrutiJ-01
Null safety migration (#252)
2957eb6 
* Migrated Project to null safety.

Changed packages geocoder and modal_progress_hud to their null safe versions flutter_geocoder and modal_progress_hud_nsn in pubspec.yaml. Added null check operators and replaced deprecated methods with new ones.In widget_test.dart, added AdState provider to the 'ProductPage displays text and image correctly' test.

Resolves #251

* Migrated Project to null safety,changes in Tests

In widget_test.dart, added AdState provider to the 'ProductPage displays text and image correctly' test.

* Changed FirebaseAuthException to FirebaseException in remote_config.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShrutiJ-01 ShrutiJ-01

Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Null safety migration ShrutiJ-01/relic_bazaar
2 participants
@himanshusharma89 @ShrutiJ-01