[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #235 #236

Merged
merged 1 commit into from
May 16, 2021
Merged

Fixes #235 #236

merged 1 commit into from
May 16, 2021

Conversation

SapinderSingh
Copy link
Contributor

Related Issue

Proposed Changes

  • Replaced onFieldSubmitted with OnSaved
  • Removed redundant TextEditingControllers
  • Replaced positional arguments with named arguments for easy readability and maintainence.

Checklist

  • Tested
  • No Conflicts
  • Change In Code
  • Change In Documentation
  • Follows linting rules

Video

take.this.mp4

@github-actions github-actions bot added the GSSOC21 Issues created for GSSOC'21 label May 16, 2021
@Rishabh510
Copy link
Collaborator

@himanshusharma89 I think we can merge this one.

@himanshusharma89 himanshusharma89 merged commit 496970c into himanshusharma89:master May 16, 2021
@himanshusharma89 himanshusharma89 added the Level1 easy gssoc issue label May 16, 2021
@SapinderSingh SapinderSingh deleted the issue-235 branch May 17, 2021 02:23
@SapinderSingh SapinderSingh mentioned this pull request May 19, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshusharma89 himanshusharma89 himanshusharma89 approved these changes

Assignees

@SapinderSingh SapinderSingh

Labels
GSSOC21 Issues created for GSSOC'21 Level1 easy gssoc issue
Projects
None yet
Milestone
No milestone
3 participants
@SapinderSingh @Rishabh510 @himanshusharma89