[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some typos in source code comments #202

Closed
wants to merge 1 commit into from
Closed

fix some typos in source code comments #202

wants to merge 1 commit into from

Conversation

xueyumusic
Copy link
Contributor

fix some typos in source code comments

patrick-schwarz pushed a commit to patrick-schwarz/HElib that referenced this pull request Dec 6, 2019
* Context now throws LogicError when attempting to calculate security level before building the modulus chain.
@faberga
Copy link
Collaborator
faberga commented Aug 28, 2020

Hi @xueyumusic . Thank you for your contribution.

HElib has come a long way since you raised this PR. Now we have a better way to accept and review PRs.
Since there are many conflicts in this PR, could you try rebasing you fork and check whether this PR is still applicable, please?

Thank you,
Flavio

@xueyumusic
Copy link
Contributor Author

Hi, @faberga , I checked based on the latest code, it looks that almost all the typos in this PR are already fixed, except maybe only one in tableLookup.h 's compliment(maybe should be complement). I will close this PR, thank you~

@xueyumusic xueyumusic closed this Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants