Extensions to PSI Logic, Updated CI, and Bug Fixes #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for processing queries with the NOT operator homomorphically. Introduced the NOT Expr, and a corresponding inline NOT QueryExpr Within the weights, or CNF, framework: * Extensions to the ExpandOr() function to queries with NOT operators, via a new function negate() * New function Tidy() which eliminates duplicate columns in inner clauses, or columns and their negation in inner clauses that can be created by squashing ORs. It also eliminates empty clauses, * Put the code from build() which constructed the corresponding weights into a new function buildWeights(), and extended this to the case there are negations of columns * New framework which evaluates queries homomorphically directly from the string: * New function removeOr() within the QueryBuilder class which generates a new query string which is logically equivalent, but only has Ands and Nots * Overloaded contains() function that takes a string instead of a QueryType, and evaluates the RPN directly using a stack of ciphertexts Co-authored-by: @TabOg Co-authored-by: @jlhcrawford Co-authored-by: @hamishun
* Fix deprecated sprintf in GTestApproxNums.cpp
Removed ubuntu-20.04 Updates ubuntu-22.04 Added macOS 12, and MacOS 13
faberga
approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for processing queries with the NOT operator homomorphically.
Introduced the NOT Expr, and a corresponding inline NOT QueryExpr Within the weights, or CNF, framework:
Updated CI
Bug Fix for unsafe use of sprintf
Co-authored-by: @TabOg
Co-authored-by: @jlhcrawford
Co-authored-by: @hamishun
Co-authored-by: @faberga