feat: CLI collection runner command generation UI flow #4141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f282a8
to
3cf412e
Compare
4 tasks
126ea13
to
c9efc07
Compare
nivedin
requested changes
Jun 26, 2024
There was a problem hiding this comment.
- for the collection 'Details' tab section in properties can we remove the 'Save' button and conditional render it as 'Copy' since save in that context does not do anything. Similar to Environment Properties modal
- we can add a copy button close to the text, similar to the other modals.
17b1e95
to
bffb78a
Compare
Discussed separately, the copy to clipboard action next to the generated CLI command made it appear crowded and a primary copy action already exists. |
nivedin
approved these changes
Jun 26, 2024
amk-dev
reviewed
Jun 27, 2024
packages/hoppscotch-common/src/components/collections/Collection.vue
Outdated
Show resolved
Hide resolved
amk-dev
requested changes
Jun 27, 2024
Add a new `properties` action under the context menu for environments.
Rename the `Run in CLI` action under the collection context menu to `Run collection`.
…operties` component The existing usages guarantee the above prop to be an object.
bffb78a
to
26260b6
Compare
26260b6
to
9e1a454
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#4095 adds support for accessing collections/environments from a team workspace straightaway via the CLI by supplying the respective IDs without having to obtain an export. This PR includes UI flow updates to support the same where the CLI command to run a certain collection with the ID can be obtained (optionally including the active environment) via the context menu.
Closes HFE-520.
Changes
Fixes the case about dismissing the environment context menu (opened via pressing the
Morekebab menu) via pressingEscape, which results in an exception.Made
editingPropertiesa required prop for theCollectionsPropertiescomponent withnullremoved from the types since the existing usages guarantee the above prop to be an object.New
Run collectionaction under the context menu option for collections that displays the modal with the respective CLI command to run the collection, optionally including any active environment. It can also be accessed while hovering over a certain collection.The
Collection Propertiesmodal now includes a newDetailstab that shows the collection ID.There'll be a new
propertiesaction under the context menu for environments that opens a newEnvironment Propertiesmodal which displays the respective environment ID.