[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local_rank_op for tensorflow #3940

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Fix local_rank_op for tensorflow #3940

merged 1 commit into from
Jun 6, 2023

Conversation

gaopengff
Copy link
Contributor
@gaopengff gaopengff commented Jun 6, 2023 •
edited
Loading

This PR is to corrret horovod_local_rank method of tensorflow.

Checklist before submitting

  • Did you read the contributor guide?
  • Did you update the docs?
  • Did you write any tests to validate this change?
  • Did you update the CHANGELOG, if this change affects users?

Description

Fixes # (issue).
#3939

Review process to land

  1. All tests and other checks must succeed.
  2. At least one member of the technical steering committee must review and approve.
  3. If any member of the technical steering committee requests changes, they must be addressed.

@gaopengff gaopengff mentioned this pull request Jun 6, 2023
Closed
@gaopengff
Fix horovod_local_rank
b4fef08 
Signed-off-by: gaopengf <pengfei.gao@intel.com>
@maxhgerlach maxhgerlach linked an issue Jun 6, 2023 that may be closed by this pull request
hvd.local_rank_op() returns wrong result with tensorflow #3939
Closed
@maxhgerlach maxhgerlach self-requested a review June 6, 2023 07:40
maxhgerlach
maxhgerlach approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator
@maxhgerlach maxhgerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for identifying and fixing this bug, @gaopengff!

Just triggered the CI workflow, can merge then.

@gaopengff
Copy link
Contributor Author

My pleasure.

@github-actions
Copy link
github-actions bot commented Jun 6, 2023 •
edited
Loading

Unit Test Results

     977 files  +   409       977 suites  +409   12h 6m 36s ⏱️ + 2h 45m 38s
     887 tests ±       0       770 ✔️ +     79     116 💤  -      79  1 ❌ ±0 
21 895 runs  +9 157  15 302 ✔️ +6 663  6 592 💤 +2 495  1 ❌  - 1 

For more details on these failures, see this check.

Results for commit b4fef08. ± Comparison against base commit 7f875b2.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
github-actions bot commented Jun 6, 2023 •
edited
Loading

Unit Test Results (with flaky tests)

  1 117 files  +     494    1 117 suites  +494   12h 57m 32s ⏱️ + 2h 34m 38s
     887 tests ±         0       770 ✔️ +     79     116 💤  -      79  1 ❌ ±0 
25 125 runs  +11 617  17 289 ✔️ +7 950  7 834 💤 +3 671  2 ❌  - 4 

For more details on these failures, see this check.

Results for commit b4fef08. ± Comparison against base commit 7f875b2.

♻️ This comment has been updated with latest results.

@maxhgerlach maxhgerlach changed the title Fix horovod_local_rank method of tensorflow Fix local_rank_op for tensorflow Jun 6, 2023
@maxhgerlach maxhgerlach merged commit 3d24900 into horovod:master Jun 6, 2023
44 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhgerlach maxhgerlach maxhgerlach approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hvd.local_rank_op() returns wrong result with tensorflow
2 participants
@gaopengff @maxhgerlach