[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deepbox Protocol #15989

Open
wants to merge 137 commits into
base: master
Choose a base branch
from
Open

Deepbox Protocol #15989

wants to merge 137 commits into from

Conversation

chenkins
Copy link
Contributor
@chenkins chenkins commented Jun 4, 2024

No description provided.

dkocher
dkocher reviewed Jun 5, 2024
View reviewed changes
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxIdProvider.java Outdated Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxSession.java Outdated Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxSession.java Outdated Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxSession.java Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxSession.java Outdated Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxProtocol.java Outdated Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxExceptionMappingService.java Outdated Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxListService.java Outdated Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxListService.java Outdated Show resolved Hide resolved
dkocher
dkocher reviewed Jun 14, 2024
View reviewed changes
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxAttributesFinderFeature.java Outdated Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxListService.java Outdated Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxListService.java Outdated Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxListService.java Outdated Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxListService.java Outdated Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxMoveFeature.java Outdated Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxReadFeature.java Outdated Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxReadFeature.java Outdated Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxWriteFeature.java Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxWriteFeature.java Outdated Show resolved Hide resolved
dkocher
dkocher reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor
@dkocher dkocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve TODOs

deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxWriteFeature.java Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxWriteFeature.java Outdated Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxPathContainerService.java Outdated Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxIdProvider.java Outdated Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxIdProvider.java Outdated Show resolved Hide resolved
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxIdProvider.java Show resolved Hide resolved
deepbox/src/test/java/ch/cyberduck/core/deepbox/DeepboxListServiceTest.java Outdated Show resolved Hide resolved
@chenkins chenkins force-pushed the feature/deepbox branch 2 times, most recently from e3c5a77 to 2feee7c Compare June 21, 2024 14:10
ylangisc and others added 22 commits June 27, 2024 16:57
@ylangisc @chenkins
POC for DeepBox.
4108318
@ylangisc @chenkins
POC for DeepBox.
da1154f
@chenkins
Implement DeepboxIdProvider and DeepboxListService (WiP).
564db81
@chenkins
Update copyright.
4b6a1b9
@chenkins
Mark DeepBoxListServiceTest as integration test.
0ac46ab
@chenkins
Remove unused constants.
c81383c
@chenkins
Remove obsolete override.
250452d
@chenkins
Remove multipart feature.
f61ae44
@chenkins
Set creation and modification date on nodes.
3248386
@chenkins
Fix DeepboxIdProvider.
0cc99fb
@chenkins
Extract container levels to DeepboxPathContainerService.
9d9204e
@chenkins
Add Deepbox directory feature WiP.
c9bc707
@chenkins
Extract path attributes to attributes finder (WiP).
ed70b7c
@chenkins
Refactor deepbox id provider.
9acfe96
@chenkins
Check attributes in DeepboxListServiceTest.
fc309ea
@chenkins
Add test Deepbox Directory feature and Path Container Service.
ba61764
@chenkins
Fix deepbox id provider.
eeccaaa
@chenkins
Add deepbox read feature WiP.
bfa076e
@chenkins
Add deepbox find feature.
11b84c7
@chenkins
Fix deepbox directory feature test.
604c7fd
@chenkins @dkocher
Update deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxSession…
ae92bab 
….java

Co-authored-by: David Kocher <dkocher@iterate.ch>
@chenkins
Revert.
0da98db
@chenkins chenkins marked this pull request as ready for review June 28, 2024 16:55
@chenkins chenkins requested a review from a team as a code owner June 28, 2024 16:55
@chenkins chenkins requested a review from dkocher June 28, 2024 16:55
@chenkins chenkins marked this pull request as draft June 29, 2024 07:09
@chenkins chenkins marked this pull request as draft June 29, 2024 07:09
@chenkins chenkins marked this pull request as ready for review July 1, 2024 07:32
@chenkins chenkins requested a review from dkocher July 2, 2024 08:09
dkocher
dkocher requested changes Jul 2, 2024
View reviewed changes
deepbox/src/main/java/ch/cyberduck/core/deepbox/DeepboxIdProvider.java Outdated
Comment on lines 103 to 117
final List<Path> segs = pathToList(file);
for(final Path seg : segs) {
if(StringUtils.isNotBlank(seg.attributes().getFileId())) {
continue;
}
final String cachedSeg = super.getFileId(file);
if(cachedSeg != null) {
continue;
}
final String ret = lookupFileId(seg);
// fail if one of the segments cannot be found
if(StringUtils.isEmpty(ret)) {
return null;
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably not lookup IDs for the full tree for performance reason.

@dkocher dkocher added this to the 10.0 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkocher dkocher dkocher requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chenkins @dkocher @ylangisc