[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit pytest version to <8.1 #10334

Merged
merged 1 commit into from
Mar 4, 2024
Merged

limit pytest version to <8.1 #10334

merged 1 commit into from
Mar 4, 2024

Conversation

skshetry
Copy link
Member
@skshetry skshetry commented Mar 4, 2024 •
edited
Loading

Changes in pytest==8.1.0 breaks flaky plugin.

See box/flaky#198.

It's breaking the CI.

@skshetry
limit pytest version to <8.1
d76efa6 
Change in pytest==8.1.0 breaks `flaky` plugin.

See box/flaky#198.
@codecov Codecov
Copy link
codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (257ea5f) to head (d76efa6).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10334      +/-   ##
==========================================
- Coverage   90.60%   90.22%   -0.39%     
==========================================
  Files         500      500              
  Lines       38591    38591              
  Branches     5573     5564       -9     
==========================================
- Hits        34965    34818     -147     
- Misses       2983     3081      +98     
- Partials      643      692      +49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skshetry skshetry merged commit bc95b65 into main Mar 4, 2024
19 checks passed
@skshetry skshetry deleted the skshetry-patch-1 branch March 4, 2024 04:46
@shcheklein
Copy link
Member

Will we detect when there is a fix available?

@skshetry
Copy link
Member Author
skshetry commented Mar 4, 2024

The change is intentional in pytest, so it will likely have to be fixed in flaky. In that case, there will be updates in the above issue.

@shcheklein
Copy link
Member

yep, but how will we know to bump it again? will there be a dependabot PR?

@skshetry
Copy link
Member Author
skshetry commented Mar 4, 2024

I will revert this PR once the issue gets fixed.

And, yes there will be dependabot PR for newer pytest releases. But the problem is not with pytest, but with flaky.

@shcheklein
Copy link
Member

But the problem is not with pytest, but with flaky.

yep, I got that part. Was to double check that we have a way to get back to it via some automated PR. Thanks @skshetry .

skshetry added a commit that referenced this pull request Mar 4, 2024
@skshetry
Revert "limit pytest version to <8.1 (#10334)"
129f092 
This reverts commit bc95b65.
skshetry added a commit that referenced this pull request Mar 4, 2024
@skshetry
replace flaky with pytest-rerunfailures (#10335)
3b2e031 
* Revert "limit pytest version to <8.1 (#10334)"

This reverts commit bc95b65.

* replace flaky with pytest-rerunfailures

`flaky` project seems to be unmaintained (see box/flaky#192).
`pytest-rerunfailures` seems to be maintained under `pytest-dev`
and tests 5 minor releases of pytest.

Note that this plugin is not compatible with `flaky` plugin.
You will have to uninstall it if it exists.
@The-Compiler
Copy link

FWIW, given that flaky hasn't seen a release since 2020 and nobody reacted to an issue asking if it was still active, this is unlikely to improve in the forseeable future. You might want to look at migrating to e.g. pytest-rerunfailures instead.

@skshetry
Copy link
Member Author
skshetry commented Mar 4, 2024

Thanks @The-Compiler for the suggestion. I have replaced flaky with pytest-rerunfailures in #10335. 🙂

BradyJ27 pushed a commit to BradyJ27/dvc that referenced this pull request Apr 22, 2024
@skshetry @BradyJ27
limit pytest version to <8.1 (iterative#10334)
21c8d71 
Change in pytest==8.1.0 breaks `flaky` plugin.

See box/flaky#198.
BradyJ27 pushed a commit to BradyJ27/dvc that referenced this pull request Apr 22, 2024
@skshetry @BradyJ27
replace flaky with pytest-rerunfailures (iterative#10335)
26a2413 
* Revert "limit pytest version to <8.1 (iterative#10334)"

This reverts commit bc95b65.

* replace flaky with pytest-rerunfailures

`flaky` project seems to be unmaintained (see box/flaky#192).
`pytest-rerunfailures` seems to be maintained under `pytest-dev`
and tests 5 minor releases of pytest.

Note that this plugin is not compatible with `flaky` plugin.
You will have to uninstall it if it exists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skshetry @shcheklein @The-Compiler