[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The closing brackets or keywords are not highlighted #53

Closed
shunwen opened this issue May 7, 2018 · 14 comments
Closed

The closing brackets or keywords are not highlighted #53

shunwen opened this issue May 7, 2018 · 14 comments
Labels

Comments

@shunwen
Copy link
shunwen commented May 7, 2018

Your programming language

Ruby

Expected Behavior

  • The closing brackets or keywords should be highlighted correctly

Current Behavior

  • The closing brackets or keywords are not highlighted

signup_modal rb core 2018-05-07 13-59-17

Your Environment

  • Plugin version: 5.2
  • IDE & Operating System version, comment your env as below(go to "About IntelliJ IDEA" -> click the "copy" icon):
RubyMine 2018.1.1
Build #RM-181.4445.97, built on April 11, 2018
Licensed to Shunwen Hsiao
Subscription is active until February 4, 2019
JRE: 1.8.0_152-release-1136-b27 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.13.4
@jdreesen
Copy link
jdreesen commented May 7, 2018

This is broken (at least for curly brackets) in PHP, too.

grafik

Your programming language

PHP

Your Environment

  • Plugin version: 5.2
  • IDE & Operating System version:
PhpStorm 2018.1.1
Build #PS-181.4445.72, built on April 9, 2018
JRE: 1.8.0_152-release-1136-b27 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 4.13.0-39-generic

@izhangzhihao
Copy link
Owner

@jdreesen Did you mean older version works fine?

@izhangzhihao
Copy link
Owner

It will be great if I will have your code gists.

@izhangzhihao
Copy link
Owner

Seems break by 9cecce7

@izhangzhihao
Copy link
Owner

@shunwen It works before version 5.1, I'm sorry that I break that.

@izhangzhihao
Copy link
Owner

Related to #48

@izhangzhihao
Copy link
Owner
izhangzhihao commented May 7, 2018

Related to #55

@shunwen
Copy link
Author
shunwen commented May 7, 2018

@izhangzhihao No problem at all, thank you for this amazing plugin. If you need ruby snippet I copied the example from RubyMine to this gist: https://gist.github.com/shunwen/be6ae7019a71593c070fa57ab703992b

@izhangzhihao
Copy link
Owner

All fixed

@izhangzhihao
Copy link
Owner

New version 5.4 just published, you will receive this update serval days later. Or use this intellij-rainbow-brackets-5.4.zip

@shunwen
Copy link
Author
shunwen commented May 7, 2018

Hi @izhangzhihao , thanks for the quick fix. The end keyword is highlighted correctly in Ruby now, but the brackets )] are still not highlighted.

@izhangzhihao
Copy link
Owner

@shunwen did you mean "[()]" not working? Does it works in previous version?

@shunwen
Copy link
Author
shunwen commented May 8, 2018

@izhangzhihao I think everything works fine in version 5.1, and every closing brackets/keywords are broken in version 5.2. In version 5.4, sometimes it works sometimes it doesn't.

scratch_51 rb 2018-05-08 08-28-55

@izhangzhihao
Copy link
Owner

intellij-rainbow-brackets-5.4.zip

try this build snapshot version. This issue should been fixed.

izhangzhihao added a commit that referenced this issue May 8, 2018
izhangzhihao added a commit that referenced this issue May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants