[PPML] turn keywhiz client from CLI to native methods #7253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BigDL KMS Frontend used to communicate keywhiz server through keywhiz CLI (calling jars in java CLI), and this causes an inability to run BigDL KMS in SGX environment since such a process creates many JVM process that leads to high overhead for SGX execution. Also, the JVM creations make the request latency larger and therefore worsen QoE.
As a result, we turn from CLI to directly calling native methods in external keywhiz jars by applying reflection as a solution.
1. Why the change?
As above.
2. User API changes
None.
3. Summary of the change
Turn keywhiz client from CLI to native methods in BigDL KMS Frontend.
4. How to test?