generated from ipdxco/github-as-code
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes sync workflow and syncs YAML with GH #44
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galargh
commented
Aug 24, 2022
Before merge, verify that all the following plans are correct. They will be applied as-is after the merge. Terraform plansipfs
|
galargh
commented
Aug 24, 2022
galargh
commented
Aug 24, 2022
galargh
commented
Aug 24, 2022
galargh
commented
Aug 24, 2022
Proceeding with this since it only applies maintenance changes/previously approved changes. |
@reidlw I should have a new invite to the org in your email now. You should accept it within 7 days. |
Thanks for handling @galargh and finding ways to make this more robust. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed #43 wasn't properly applied. That's because it tried to create a repository that already existed. To pull existing resources under GitHub Management, one has to run the Sync workflow and merge the PR that it creates. That's what I did here. FYI, we want to put sync runs on weekly schedule soon - ipdxco/github-as-code#56
One more thing that I did here was to fix the sync script itself (715f4b3). As it turns out it didn't handle files during repo renames properly.
Finally, I did restore the changes that were supposed to be applied/preserved:
js.ipfs.io
->js.ipfs.tech
reidlw
access to org/w3dt-stewards team