-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document global options (-r, --enc and --timeout) #4479
base: master
Are you sure you want to change the base?
Conversation
License: MIT Signed-off-by: <keks@cryptoscope.co>
Ideally they'd also show up in the block below that summary line:
These ^ are the global options that have been documented so far. |
@keks is there a reason we don't list these options under the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These options should also be listed under the Root cmds.Command in core/commands/root.go (here https://github.com/ipfs/go-ipfs/blob/master/core/commands/root.go#L87) unless there is a good reason not to.
If I understand how things work this should add them under the summary as @lgierth requested.
@magik6k do you think you could handle getting this one ready to go? |
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
Looks like the options are now documented in |
Closes #4432.
Is this what you had in mind or do you want more detail?