Update commands with progress bars #4139
Conversation
- Show speed on `ipfs get` - Show a progress bar (with speed) on `ipfs pin add` License: MIT Signed-off-by: John Ott <john@johnott.us>
| if err == nil { | ||
| stat, err := node.Stat() | ||
| if err == nil { | ||
| cnt = stat.LinksSize + stat.DataSize |
There was a problem hiding this comment.
I'm not entirely sure if this is correct. I tried using stat.BlockSize but that did not seem to include the DataSize measurement.
|
I'm not entirely sure how you guys would like these tests fixed. Looks like a failure due to the changed format of |
|
Hi @jbott
Could you be more specific here. |
|
Oops, sorry I wasn't too explicit in what this patch was supposed to accomplish. This adds size based progress bars to the The specific test that is failing is here: https://github.com/ipfs/go-ipfs/blob/master/test/sharness/t0085-pins.sh#L96 It's due to the change in the output format of the If you guys have a preferred way of fixing this test (or alternatively just removing it), I would be happy to do so. |
ipfs getipfs pin addLicense: MIT
Signed-off-by: John Ott john@johnott.us